Skip to content

[Fixes #12957] Metadata editor: customizable title and description labels#12990

Merged
etj merged 1 commit intomasterfrom
12957_metadata_custom_labels
Mar 21, 2025
Merged

[Fixes #12957] Metadata editor: customizable title and description labels#12990
etj merged 1 commit intomasterfrom
12957_metadata_custom_labels

Conversation

@etj
Copy link
Copy Markdown
Contributor

@etj etj commented Mar 21, 2025

Rationale in #12957 and comments.

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj added this to the 5.0.0 milestone Mar 21, 2025
@etj etj requested review from giohappy and mattiagiupponi March 21, 2025 14:25
@etj etj self-assigned this Mar 21, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Mar 21, 2025
@etj etj linked an issue Mar 21, 2025 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 55.26316% with 17 lines in your changes missing coverage. Please review.

Project coverage is 67.96%. Comparing base (9980edd) to head (431d065).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12990      +/-   ##
==========================================
- Coverage   67.97%   67.96%   -0.02%     
==========================================
  Files         980      980              
  Lines       59246    59261      +15     
  Branches     6922     6928       +6     
==========================================
+ Hits        40272    40276       +4     
- Misses      17328    17337       +9     
- Partials     1646     1648       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@etj etj merged commit 24aae53 into master Mar 21, 2025
19 of 21 checks passed
@etj etj deleted the 12957_metadata_custom_labels branch March 21, 2025 15:21
@mattiagiupponi mattiagiupponi removed this from the 5.0.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed enhancement master metadata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metadata editor: customizable title and description labels

2 participants