Fix master build

geonode/metadata/api/views.py

@@ -16,6 +16,7 @@
 # along with this program. If not, see <http://www.gnu.org/licenses/>.
 #
 #########################################################################
+import json
 import logging
 
 from dal import autocomplete
@@ -107,10 +108,12 @@
 
             elif request.method == "PUT":
                 logger.debug(f"handling request {request.method}")
-                # try:
-                #     logger.debug(f"handling content {json.dumps(request.data, indent=3)}")
-                # except Exception as e:
-                #     logger.warning(f"Can't parse JSON {request.data}: {e}")
+                try:
+                    json.loads(request.data)
+                except Exception as e:
+                    message = f"Can't parse JSON {request.data}: {e}"
+                    logger.warning(message)
+                    return Response(message, status=400)
                 errors = metadata_manager.update_schema_instance(resource, request.data)
 
                 msg_t = (

geonode/metadata/tests/tests.py

@@ -252,24 +252,17 @@ def test_put_patch_schema_instance_with_errors(self, mock_has_permission, mock_u
         )
         mock_update_schema_instance.assert_called_with(self.resource, fake_payload)
 
-    @patch("geonode.metadata.manager.metadata_manager.update_schema_instance")
     @patch("geonode.base.api.permissions.UserHasPerms.has_permission", return_value=True)
-    def test_put_patch_schema_instance_with_bad_payload(self, mock_has_permission, mock_update_schema_instance):
+    def test_put_patch_schema_instance_with_bad_payload(self, mock_has_permission):
         """
         Test the PUT method with an invalid json payload
         """
 
         url = reverse("metadata-schema_instance", kwargs={"pk": self.resource.pk})
         fake_payload = "I_AM_BAD"
 
-        # Set fake errors
-        errors = {"fake_error_1": "Field 'title' is required", "fake_error_2": "Invalid value for 'type'"}
-        mock_update_schema_instance.return_value = errors
-
         response = self.client.put(url, data=fake_payload, format="json")
-        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
-
-        mock_update_schema_instance.assert_called_with(self.resource, fake_payload)
+        self.assertEqual(response.status_code, 400)
 
     @patch("geonode.base.api.permissions.UserHasPerms.has_permission", return_value=True)
     def test_resource_not_found(self, mock_has_permission):