[Fixes #13514] Extended the asset link serializer to inform the client whether an asset can be deleted or not

[sijandh35]

Fixes #13514

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[gemini-code-assist]

Summary of Changes

Hello @sijandh35, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the asset management system by providing clients with explicit information about an asset's deletability status. It introduces a new utility function to determine if an asset can be deleted based on predefined rules and integrates this information directly into the API responses for asset links. This change allows frontend applications to accurately reflect deletion permissions to users, improving the overall user experience and preventing attempts to delete protected assets.

Highlights

• New is_asset_deletable Utility Function: A new utility function is_asset_deletable has been introduced in geonode/assets/utils.py. This function determines if an asset can be deleted, currently protecting assets with titles like "Original" or "Files" from deletion.
• Asset Deletability Exposed in API: The AssetLinkSerializer in geonode/base/api/serializers.py has been extended. It now includes a deletable boolean field within the extras dictionary for each asset link, informing the client whether the associated asset can be deleted.
• Refactored unlink_asset Logic: The unlink_asset function in geonode/assets/utils.py has been updated to utilize the new is_asset_deletable function, centralizing the logic for checking asset protection before attempting to unlink or delete.
• Comprehensive Unit Tests: New unit tests have been added in geonode/base/tests.py under the TestDeletableAssetKey class. These tests verify that the deletable property is correctly returned by the serializer for both protected and regular assets.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully extends the asset link serializer to include a deletable flag, informing the client whether an asset can be removed. The implementation is clean, centralizing the logic in a new is_asset_deletable utility function and adding corresponding tests to validate the behavior. My review includes a couple of suggestions to enhance code conciseness in the new utility function and to improve the robustness and clarity of the new test case.

[codecov]

Codecov Report

❌ Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.71%. Comparing base (8067a21) to head (51c5f11).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #13518   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files         921      921           
  Lines       54192    54222   +30     
  Branches     6168     6170    +2     
=======================================
+ Hits        39945    39972   +27     
- Misses      12644    12648    +4     
+ Partials     1603     1602    -1     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.