[Fixes #13507] Refactor of the create dataset page #13580
Merged
Conversation
mattiagiupponi
commented
Oct 10, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13580 +/- ##
==========================================
+ Coverage 72.52% 72.56% +0.04%
==========================================
Files 931 932 +1
Lines 55216 55469 +253
Branches 7437 7474 +37
==========================================
+ Hits 40044 40250 +206
- Misses 13569 13606 +37
- Partials 1603 1613 +10 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
@mattiagiupponi I noticed the following while testing:
- error creating a dataset using an attribute with initial letter uppercase
Dataset could not be created in GeoServer The CQL source expression for attribute A refers to attributes unavailable in the data source: [A]. Request: d3bdac0a-f543-4530-9b25-88308e657e68
curl 'http://localhost/api/v2/uploads/upload' \
-H 'Accept: application/json, text/plain, */*' \
-H 'Accept-Language: en-US,en;q=0.9' \
-H 'Cache-Control: no-cache' \
-H 'Connection: keep-alive' \
-H 'Content-Type: application/json' \
-H 'Origin: http://localhost:8081' \
-H 'Pragma: no-cache' \
-H 'Sec-Fetch-Dest: empty' \
-H 'Sec-Fetch-Mode: cors' \
-H 'Sec-Fetch-Site: same-origin' \
--data-raw '{"action":"create","title":"ffff","geom":"Point","attributes":{"A":{"type":"string","nillable":true}}}'
- Is it possible to skip the thumbnail creation only for the create action workflow? Maybe could this help to speed up the creation of a dataset?
Contributor
Author
changes / fix pushed |
giohappy
reviewed
Oct 20, 2025
| return False | ||
|
|
||
|
|
||
| def add_attributes_to_xml(attributes_dict, xml): |
Contributor
There was a problem hiding this comment.
@mattiagiupponi IMHO this should go into geoserver-restconfig. We read restrictions from it, we should write them too.
giohappy
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #13507
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.