Conversation
Summary of ChangesHello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a structural reorganization of the project by renaming the top-level 'scripts' directory to 'misc'. This change aims to improve the logical grouping of various utility files. Additionally, it removes specific Celery daemon management scripts, suggesting an updated approach to how Celery workers are configured or initiated within the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the project structure by renaming the scripts folder to misc and removes legacy Celery init scripts. This is a good cleanup effort, especially for a project primarily using Docker. However, I've identified a potential issue where some Celery worker configurations from the deleted celeryd-default file, such as time-limit and concurrency, may not have been correctly migrated to the new celery.sh script. I've added a specific comment highlighting this discrepancy.
| CELERYD_CHDIR="" | ||
|
|
||
| # Extra command-line arguments to the worker | ||
| CELERYD_OPTS="--time-limit=300 --concurrency=8 -E" |
There was a problem hiding this comment.
This configuration file is being deleted, but it appears some of the Celery worker options defined here have not been fully migrated to the new startup scripts (celery.sh, celery_dev.sh).
Specifically:
CELERYD_OPTSin this file sets--time-limit=300and--concurrency=8.- The new scripts (
celery.shandcelery_dev.sh) use--concurrency=2and do not set a--time-limit.
This change in concurrency from 8 to 2 and the removal of the task time limit could significantly impact the performance and reliability of your workers. Was this change intentional? If these settings are still required, they should be added to the new Celery startup scripts.
No description provided.