Skip to content

Renamed scripts folder#13638

Merged
giohappy merged 2 commits intomasterfrom
cleanup_and_rename_scripts_folder
Oct 20, 2025
Merged

Renamed scripts folder#13638
giohappy merged 2 commits intomasterfrom
cleanup_and_rename_scripts_folder

Conversation

@giohappy
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 20, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a structural reorganization of the project by renaming the top-level 'scripts' directory to 'misc'. This change aims to improve the logical grouping of various utility files. Additionally, it removes specific Celery daemon management scripts, suggesting an updated approach to how Celery workers are configured or initiated within the application.

Highlights

  • Directory Renaming: The 'scripts' directory has been renamed to 'misc' to better categorize its contents.
  • Celery Script Removal: The 'celeryd' and 'celeryd-default' initialization scripts, previously located under 'scripts/celery', have been removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project structure by renaming the scripts folder to misc and removes legacy Celery init scripts. This is a good cleanup effort, especially for a project primarily using Docker. However, I've identified a potential issue where some Celery worker configurations from the deleted celeryd-default file, such as time-limit and concurrency, may not have been correctly migrated to the new celery.sh script. I've added a specific comment highlighting this discrepancy.

CELERYD_CHDIR=""

# Extra command-line arguments to the worker
CELERYD_OPTS="--time-limit=300 --concurrency=8 -E"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This configuration file is being deleted, but it appears some of the Celery worker options defined here have not been fully migrated to the new startup scripts (celery.sh, celery_dev.sh).

Specifically:

  • CELERYD_OPTS in this file sets --time-limit=300 and --concurrency=8.
  • The new scripts (celery.sh and celery_dev.sh) use --concurrency=2 and do not set a --time-limit.

This change in concurrency from 8 to 2 and the removal of the task time limit could significantly impact the performance and reliability of your workers. Was this change intentional? If these settings are still required, they should be added to the new Celery startup scripts.

@giohappy giohappy merged commit 1a64c2a into master Oct 20, 2025
6 of 13 checks passed
@giohappy giohappy deleted the cleanup_and_rename_scripts_folder branch October 20, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants