Skip to content

Add missing resource base create notification#13652

Merged
giohappy merged 2 commits intomasterfrom
fix_missing_resourcebase_notifications
Oct 28, 2025
Merged

Add missing resource base create notification#13652
giohappy merged 2 commits intomasterfrom
fix_missing_resourcebase_notifications

Conversation

@giohappy
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 22, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @giohappy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a missing notification event within the system. It introduces a specific notification for when a new resource is created, ensuring that the system can properly track and inform about the creation of base resources. This enhancement fills a gap in the existing notification framework, providing more comprehensive event coverage.

Highlights

  • New Notification Type: A new notification type, resourcebase_created, has been introduced to signal when a resource is successfully created.
  • Notification Definition: The new notification includes display names for the event, such as 'Resource is created', making it user-friendly.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds a new notification type, resourcebase_created, to the BaseAppConfig in geonode/base/apps.py. This notification is intended to inform users when a new resource is created. The review focuses on ensuring the correctness and clarity of the added notification.

Comment on lines 40 to 43
"resourcebase_created",
_("Resource is created"),
_("Resource is created"),
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description for the resourcebase_created notification is identical to the display name. To provide more clarity to users, consider elaborating on the description to specify the context or purpose of this notification.

For example, the description could be: "A notification sent when a new resource is successfully created in GeoNode."

        (
            "resourcebase_created",
            _("Resource is created"),
            _("A notification sent when a new resource is successfully created in GeoNode."),
        ),

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.52%. Comparing base (591f4c6) to head (e85a63c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #13652       +/-   ##
===========================================
+ Coverage   24.03%   72.52%   +48.49%     
===========================================
  Files         931      931               
  Lines       55216    55216               
  Branches     7437     7437               
===========================================
+ Hits        13269    40044    +26775     
+ Misses      41545    13569    -27976     
- Partials      402     1603     +1201     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy merged commit 3a532f7 into master Oct 28, 2025
18 checks passed
@giohappy giohappy deleted the fix_missing_resourcebase_notifications branch October 28, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants