Skip to content

[Fixes #13901] Fixes Indexing fails when search string contains blanks#13927

Open
sijandh35 wants to merge 2 commits intomasterfrom
ISSUE_13901
Open

[Fixes #13901] Fixes Indexing fails when search string contains blanks#13927
sijandh35 wants to merge 2 commits intomasterfrom
ISSUE_13901

Conversation

@sijandh35
Copy link
Contributor

Fixes #13901

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@sijandh35 sijandh35 self-assigned this Feb 2, 2026
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 2, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sijandh35, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical indexing failure that occurred when search queries contained blank spaces. The changes refine the search string processing logic within the AsteriskSearchQuery class, ensuring that user-provided search terms are properly sanitized, tokenized, and formatted. This prevents malformed queries and enables accurate multi-word prefix matching, significantly improving the reliability and functionality of the search indexing system.

Highlights

  • Improved Search String Handling: The AsteriskSearchQuery class now correctly processes search strings, especially those containing multiple words or blanks, preventing indexing failures.
  • Enhanced Sanitization and Tokenization: Search input is now sanitized, stripped of leading/trailing whitespace, and tokenized, ensuring each word is properly formatted for prefix matching and ordered search.
  • Robust Empty Search Query Management: Empty or purely whitespace search inputs are gracefully handled by defaulting to a wildcard (*) search, avoiding malformed queries.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue where indexing fails for search strings containing blanks. The change correctly tokenizes the search string and constructs a phrase search query using the <-> operator for PostgreSQL, which enforces the order of search terms. This is a good improvement. However, the fix is incomplete for cases where the search string is empty or consists only of whitespace, which will still result in a database error. I've added a comment with a suggestion to handle this edge case correctly.

@sijandh35 sijandh35 marked this pull request as ready for review February 3, 2026 14:17
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.19%. Comparing base (6a35d7e) to head (e7ad35d).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13927      +/-   ##
==========================================
- Coverage   74.19%   74.19%   -0.01%     
==========================================
  Files         944      947       +3     
  Lines       56468    56620     +152     
  Branches     7651     7676      +25     
==========================================
+ Hits        41899    42011     +112     
- Misses      12885    12921      +36     
- Partials     1684     1688       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sijandh35 sijandh35 requested review from etj and giohappy February 3, 2026 14:53
@giohappy giohappy removed their request for review February 6, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New indexing fails when search string contains blanks

1 participant