feat(AVZP-66): BING_API_KEY setting is now configurable from values.yaml#229
Merged
mwallschlaeger merged 3 commits intoGeoNodeUserGroup-DE:mainfrom Feb 20, 2025
Merged
Conversation
feat(AVZP-66): SECRET_KEY setting is now configurable from values.yaml
mwallschlaeger
approved these changes
Feb 19, 2025
Member
mwallschlaeger
left a comment
mwallschlaeger
left a comment
There was a problem hiding this comment.
yes resonable addition. will be included into the next release
mwallschlaeger
requested changes
Feb 19, 2025
Member
mwallschlaeger
left a comment
mwallschlaeger
left a comment
There was a problem hiding this comment.
linting requires, that .Values.geonode.secret.django.secretKey and .Values.geonode.secret.bing.apiKey must have default values in values.yaml. Could you add them?
Contributor
Author
|
I added default values according to the default ones provided in the geonode repo:
Also updated documentation. |
mwallschlaeger
approved these changes
Feb 20, 2025
Member
mwallschlaeger
left a comment
mwallschlaeger
left a comment
There was a problem hiding this comment.
Cool thanks for the PR
Contributor
Author
|
I noticed CI job failed. Let me know if corrections should be done on my side: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the HELM does not allow to configure the following environment variables useful for Django Backend:
This PR is a proposal to add these settings.
Type of Change
New Feature
Checklist
Please ensure that your pull request meets the following requirements:
Additional Notes
Any additional information or context regarding the pull request can be provided here.
Maybe documentation related to this feature should be improved