Skip to content

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented May 27, 2022

Changes:

  • drop Python 3.6 support (setuptools>60 needs py>3.7)
  • move setup.cfg content to pyproject.toml (PEP 621)
  • update cibuildwheel to 2.6 (requirement for pyproject.toml config with setuptools)
  • move to src/ based package structure (better for testing, building and structure)
  • use extension-helpers for openmp support in setup.py

@MuellerSeb MuellerSeb changed the title setuptools: move project data to pyproject.toml Build: update setuptools config and CI May 27, 2022
@MuellerSeb MuellerSeb self-assigned this May 27, 2022
@MuellerSeb MuellerSeb added Installation Problems during the installation of GSTools. CI/CD labels May 27, 2022
@MuellerSeb MuellerSeb added this to the v1.4 milestone May 27, 2022
@MuellerSeb
Copy link
Member Author

OpenMP support was never available in CI for macOS. There is also an open PR for clang/openmp support on macOS here: astropy/extension-helpers#42

We could wait for this PR to be merged and then we could install openmp with brew for macOS:

      - name: macos openmp install
        uses: mstksg/get-package@v1
        if: matrix.os == 'macos-latest'
        with:
          brew: libomp

@MuellerSeb MuellerSeb requested a review from LSchueler May 30, 2022 10:18
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice improvement in the setup! A small fix in the toml-file and you're ready to merge this 👍

@MuellerSeb
Copy link
Member Author

When this is implemented, we can even drop the MANIFEST.in: pypa/setuptools#3341

@MuellerSeb MuellerSeb requested a review from LSchueler June 9, 2022 10:45
@MuellerSeb MuellerSeb merged commit 5583a03 into main Jun 13, 2022
@MuellerSeb MuellerSeb deleted the 202205_build_update branch June 13, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Installation Problems during the installation of GSTools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants