Merge branch 'next' into fix/segmentation

Author: BenPinet

src/geode/mesh/builder/graph_builder.cpp

@@ -129,9 +129,6 @@ namespace geode
 
     index_t GraphBuilder::create_edge( index_t v0_id, index_t v1_id )
     {
-        OPENGEODE_ASSERT( v0_id != v1_id, "[GraphBuilder::create_edge] "
-                                          "Trying to create an edge with "
-                                          "same extremities" );
         const auto added_edge = graph_.nb_edges();
         create_edge();
         set_edge_vertex( { added_edge, 0 }, v0_id );

src/geode/mesh/core/solid_mesh.cpp

@@ -163,6 +163,8 @@ namespace
     {
         geode::PolyhedraAroundEdge result;
         const auto first_polyhedron = facet.polyhedron_id;
+        geode::index_t safety_count{ 0 };
+        constexpr geode::index_t MAX_SAFETY_COUNT{ 1000 };
         do
         {
             if( const auto adj = solid.polyhedron_adjacent_facet( facet ) )
@@ -188,7 +190,16 @@ namespace
             {
                 return std::make_tuple( std::move( result ), false );
             }
-        } while( facet.polyhedron_id != first_polyhedron );
+        } while( facet.polyhedron_id != first_polyhedron
+                 && safety_count < MAX_SAFETY_COUNT );
+        OPENGEODE_EXCEPTION( safety_count < MAX_SAFETY_COUNT,
+            "[SolidMesh::propagate_around_edge] Too many polyhedra "
+            "around edge ",
+            edge_vertices[0], " ", edge_vertices[1], " (",
+            solid.point( edge_vertices[0] ).string(), " ",
+            solid.point( edge_vertices[1] ).string(),
+            "). This is probably related to a bug in the polyhedron "
+            "adjacencies." );
         return std::make_tuple( std::move( result ), true );
     }