fix(ModelHelpers): windows issue with concurrent tasks while creating model aabb

BotellaA · web-flow · commit 65296c345793 · 2022-11-20T15:04:36.000+01:00
diff --git a/src/geode/model/helpers/aabb_model_helpers.cpp b/src/geode/model/helpers/aabb_model_helpers.cpp
@@ -51,10 +51,11 @@ namespace
         geode::index_t id{ 0 };
         for( const auto& element : range )
         {
-            tasks[id++] = async::spawn( [id, &mapping, &boxes, &element] {
+            tasks[id] = async::spawn( [id, &mapping, &boxes, &element] {
                 mapping[id] = element.id();
                 boxes[id] = element.mesh().bounding_box();
             } );
+            id++;
         }
         async::when_all( tasks.begin(), tasks.end() ).wait();
         return std::make_tuple(
@@ -93,4 +94,4 @@ namespace geode
     {
         return create_aabb< 2 >( model.surfaces(), model.nb_surfaces() );
     }
-} // namespace geode
+} // namespace geode

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,11 @@ namespace`
`51`	`51`	`geode::index_t id{ 0 };`
`52`	`52`	`for( const auto& element : range )`
`53`	`53`	`{`
`54`		`- tasks[id++] = async::spawn( [id, &mapping, &boxes, &element] {`
	`54`	`+ tasks[id] = async::spawn( [id, &mapping, &boxes, &element] {`
`55`	`55`	`mapping[id] = element.id();`
`56`	`56`	`boxes[id] = element.mesh().bounding_box();`
`57`	`57`	`} );`
	`58`	`+ id++;`
`58`	`59`	`}`
`59`	`60`	`async::when_all( tasks.begin(), tasks.end() ).wait();`
`60`	`61`	`return std::make_tuple(`
`@@ -93,4 +94,4 @@ namespace geode`
`93`	`94`	`{`
`94`	`95`	`return create_aabb< 2 >( model.surfaces(), model.nb_surfaces() );`
`95`	`96`	`}`
`96`		`-} // namespace geode`
	`97`	`+} // namespace geode`