Skip to content

fix(ApplyModelSurfacesStyle): harmonise with other stores #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
+13 −7
Merged

fix(ApplyModelSurfacesStyle): harmonise with other stores #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca3a546
fix(ApplyModelSurfacesStyle): harmonise with other stores
JulienChampagnol Nov 6, 2025
86110a8
Apply prepare changes
JulienChampagnol Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@
{
"files": ["**/components/*"],
"rules": {
"unicorn/filename-case": "PascalCase"
"unicorn/filename-case": [
"error",
{
"case": "PascalCase"
}
]
}
}
]
Expand Down
11 changes: 7 additions & 4 deletions internal_stores/model/surfaces.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@ export function useModelSurfacesStyle() {
const dataStyleStore = useDataStyleStore()
const dataBaseStore = useDataBaseStore()

function modelSurfacesStyle(id) {
return dataStyleStore.getStyle(id).surfaces
}
function modelSurfaceStyle(id, surface_id) {
if (!dataStyleStore.getStyle(id).surfaces[surface_id]) {
dataStyleStore.getStyle(id).surfaces[surface_id] = {}
if (!modelSurfacesStyle(id)[surface_id]) {
modelSurfacesStyle(id)[surface_id] = {}
}
return dataStyleStore.getStyle(id).surfaces[surface_id]
return modelSurfacesStyle(id)[surface_id]
}

function modelSurfaceVisibility(id, surface_id) {
Expand Down Expand Up @@ -74,7 +77,7 @@ export function useModelSurfacesStyle() {
}

function applyModelSurfacesStyle(id) {
const style = dataStyleStore.getStyle(id).surfaces
const style = modelSurfacesStyle(id)
const surface_ids = dataBaseStore.getSurfacesUuids(id)
return Promise.all([
setModelSurfacesVisibility(id, surface_ids, style.visibility),
Expand Down
1 change: 0 additions & 1 deletion tests/integration/microservices/back/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@
# pip-compile --output-file=tests/integration/microservices/back/requirements.txt tests/integration/microservices/back/requirements.in
#

opengeodeweb-back==5.*,>=5.12.0rc1
1 change: 0 additions & 1 deletion tests/integration/microservices/viewer/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@
# pip-compile --output-file=tests/integration/microservices/viewer/requirements.txt tests/integration/microservices/viewer/requirements.in
#

opengeodeweb-viewer==1.*,>=1.11.8rc1
Loading