Skip to content

Conversation

@BotellaA
Copy link
Member

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

mypy

🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "SetZScaling", variable has type "RpcParams") [assignment]

params = schemas.SetZScaling.from_dict(params)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "z_scale" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Register", variable has type "RpcParams") [assignment]

params = schemas.Register.from_dict(params)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Deregister", variable has type "RpcParams") [assignment]

params = schemas.Deregister.from_dict(params)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Visibility", variable has type "RpcParams") [assignment]

params = schemas.Visibility.from_dict(params)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id" [attr-defined]

self.SetVisibility(params.id, parmas.visibility)


🚫 [mypy] reported by reviewdog 🐶
Name "parmas" is not defined [name-defined]

self.SetVisibility(params.id, parmas.visibility)


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Opacity", variable has type "RpcParams") [assignment]

params = schemas.Opacity.from_dict(params)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id" [attr-defined]

self.SetOpacity(params.id, params.opacity)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "opacity" [attr-defined]

self.SetOpacity(params.id, params.opacity)


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Color", variable has type "dict[str, str | int | float | bool | dict[str, int]]") [assignment]

params = schemas.Color.from_dict(params)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, str | int | float | bool | dict[str, int]]" has no attribute "color" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
"dict[str, str | int | float | bool | dict[str, int]]" has no attribute "id" [attr-defined]

self.SetColor(params.id, color.r, color.g, color.b)


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "ApplyTextures", variable has type "RpcParams") [assignment]

params = schemas.ApplyTextures.from_dict(params)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "textures" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
Name "schemas" is not defined [name-defined]


🚫 [mypy] reported by reviewdog 🐶
Name "schemas" is not defined [name-defined]


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Visibility", variable has type "RpcParams") [assignment]


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id" [attr-defined]

self.SetPointsVisibility(params.id, params.visibility)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "visibility" [attr-defined]

self.SetPointsVisibility(params.id, params.visibility)


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Color", variable has type "dict[str, str | int | float | bool | dict[str, int]]") [assignment]


🚫 [mypy] reported by reviewdog 🐶
"dict[str, str | int | float | bool | dict[str, int]]" has no attribute "color" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
"dict[str, str | int | float | bool | dict[str, int]]" has no attribute "id" [attr-defined]

self.SetPointsColor(params.id, color.r, color.g, color.b)


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Size", variable has type "RpcParams") [assignment]


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "size" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "VertexAttribute", variable has type "RpcParams") [assignment]

params = schemas.VertexAttribute.from_dict(params)


🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id" [attr-defined]

self.displayAttributeOnVertices(params.id, pramas.name)


🚫 [mypy] reported by reviewdog 🐶
Name "pramas" is not defined [name-defined]

self.displayAttributeOnVertices(params.id, pramas.name)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

mypy

🚫 [mypy] reported by reviewdog 🐶
Name "pramas" is not defined [name-defined]

self.displayAttributeOnVertices(params.id, pramas.name)


🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined [name-defined]

def setMeshEdgesVisibility(self, rpc_params: RpcParams) -> None:


🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined [name-defined]

def setMeshEdgesColor(self, rpc_params: RpcParams) -> None:


🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined [name-defined]

def setMeshEdgesWidth(self, rpc_params: RpcParams) -> None:


🚫 [mypy] reported by reviewdog 🐶
"Color" has no attribute "width" [attr-defined]


🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined [name-defined]

def register(self, rpc_params: RpcParams) -> None:


🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined [name-defined]

def deregister(self, rpc_params: RpcParams) -> None:

@BotellaA BotellaA marked this pull request as ready for review October 22, 2025 10:37
@BotellaA BotellaA merged commit 736901f into next Oct 22, 2025
15 of 17 checks passed
@BotellaA BotellaA deleted the fix/schema-type branch October 22, 2025 19:36
@JulienChampagnol
Copy link
Member

🎉 This PR is included in version 1.11.6-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants