- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
Schema types #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema types #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
mypy
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "SetZScaling", variable has type "RpcParams")  [assignment]
| params = schemas.SetZScaling.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "z_scale"  [attr-defined]
| transform.Scale(1, 1, params.z_scale) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Register", variable has type "RpcParams")  [assignment]
| params = schemas.Register.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id"  [attr-defined]
| data_id = params.id | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Deregister", variable has type "RpcParams")  [assignment]
| params = schemas.Deregister.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id"  [attr-defined]
| self.deregisterObject(params.id) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Visibility", variable has type "RpcParams")  [assignment]
| params = schemas.Visibility.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id"  [attr-defined]
| self.SetVisibility(params.id, parmas.visibility) | 
🚫 [mypy] reported by reviewdog 🐶
Name "parmas" is not defined  [name-defined]
| self.SetVisibility(params.id, parmas.visibility) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Opacity", variable has type "RpcParams")  [assignment]
| params = schemas.Opacity.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id"  [attr-defined]
| self.SetOpacity(params.id, params.opacity) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "opacity"  [attr-defined]
| self.SetOpacity(params.id, params.opacity) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Color", variable has type "dict[str, str | int | float | bool | dict[str, int]]")  [assignment]
| params = schemas.Color.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, str | int | float | bool | dict[str, int]]" has no attribute "color"  [attr-defined]
| color = params.color | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, str | int | float | bool | dict[str, int]]" has no attribute "id"  [attr-defined]
| self.SetColor(params.id, color.r, color.g, color.b) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "ApplyTextures", variable has type "RpcParams")  [assignment]
| params = schemas.ApplyTextures.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id"  [attr-defined]
| mesh_id = params.id | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "textures"  [attr-defined]
| for tex_info in params.textures: | 
🚫 [mypy] reported by reviewdog 🐶
Name "schemas" is not defined  [name-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/model/corners/model_corners_protocols.py
Line 28 in 9036f0b
| params = schemas.Visibility.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
Name "schemas" is not defined  [name-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/model/corners/model_corners_protocols.py
Line 38 in 9036f0b
| params = schemas.Color.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Visibility", variable has type "RpcParams")  [assignment]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 32 in 9036f0b
| params = schemas.Visibility.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id"  [attr-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 33 in 9036f0b
| self.SetPointsVisibility(params.id, params.visibility) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "visibility"  [attr-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 33 in 9036f0b
| self.SetPointsVisibility(params.id, params.visibility) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Color", variable has type "dict[str, str | int | float | bool | dict[str, int]]")  [assignment]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 40 in 9036f0b
| params = schemas.Color.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, str | int | float | bool | dict[str, int]]" has no attribute "color"  [attr-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 41 in 9036f0b
| color = params.color | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, str | int | float | bool | dict[str, int]]" has no attribute "id"  [attr-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 42 in 9036f0b
| self.SetPointsColor(params.id, color.r, color.g, color.b) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "Size", variable has type "RpcParams")  [assignment]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 49 in 9036f0b
| params = schemas.Size.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id"  [attr-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 50 in 9036f0b
| self.SetPointsSize(params.id, params.size) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "size"  [attr-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 50 in 9036f0b
| self.SetPointsSize(params.id, params.size) | 
🚫 [mypy] reported by reviewdog 🐶
Incompatible types in assignment (expression has type "VertexAttribute", variable has type "RpcParams")  [assignment]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 59 in 9036f0b
| params = schemas.VertexAttribute.from_dict(params) | 
🚫 [mypy] reported by reviewdog 🐶
"dict[str, JsonValue]" has no attribute "id"  [attr-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 60 in 9036f0b
| self.displayAttributeOnVertices(params.id, pramas.name) | 
🚫 [mypy] reported by reviewdog 🐶
Name "pramas" is not defined  [name-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 60 in 9036f0b
| self.displayAttributeOnVertices(params.id, pramas.name) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
mypy
🚫 [mypy] reported by reviewdog 🐶
Name "pramas" is not defined  [name-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/points/mesh_points_protocols.py
Line 60 in 8a7539a
| self.displayAttributeOnVertices(params.id, pramas.name) | 
🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined  [name-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/edges/mesh_edges_protocols.py
Line 23 in 8a7539a
| def setMeshEdgesVisibility(self, rpc_params: RpcParams) -> None: | 
🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined  [name-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/edges/mesh_edges_protocols.py
Line 31 in 8a7539a
| def setMeshEdgesColor(self, rpc_params: RpcParams) -> None: | 
🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined  [name-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/edges/mesh_edges_protocols.py
Line 40 in 8a7539a
| def setMeshEdgesWidth(self, rpc_params: RpcParams) -> None: | 
🚫 [mypy] reported by reviewdog 🐶
"Color" has no attribute "width"  [attr-defined]
OpenGeodeWeb-Viewer/src/opengeodeweb_viewer/rpc/mesh/edges/mesh_edges_protocols.py
Line 45 in 8a7539a
| self.SetEdgesWidth(params.id, params.width) | 
🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined  [name-defined]
| def register(self, rpc_params: RpcParams) -> None: | 
🚫 [mypy] reported by reviewdog 🐶
Name "RpcParams" is not defined  [name-defined]
| def deregister(self, rpc_params: RpcParams) -> None: | 
| 
           🎉 This PR is included in version 1.11.6-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀  | 
    
No description provided.