Skip to content

fix(typo): elements => items #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025
Merged

fix(typo): elements => items #53

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9241680
fix(typo): elements => items
JulienChampagnol Mar 6, 2025
279b716
fix(schemas): all "string" => "minLength": 1
JulienChampagnol Mar 6, 2025
a2a99f2
fix typo in model apply_textures schema
JulienChampagnol Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/opengeodeweb_viewer/rpc/generic/schemas/deregister.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,15 @@
"properties": {
"viewer_object": {
"type": "string",
"enum": ["mesh", "model"]
"minLength": 1,
"enum": [
"mesh",
"model"
]
},
"id": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
12 changes: 9 additions & 3 deletions src/opengeodeweb_viewer/rpc/generic/schemas/register.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,19 @@
"properties": {
"viewer_object": {
"type": "string",
"enum": ["mesh", "model"]
"minLength": 1,
"enum": [
"mesh",
"model"
]
},
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"file_name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/edges/schemas/color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"color": {
"type": "object",
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/edges/schemas/size.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"size": {
"type": "integer"
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_viewer/rpc/mesh/edges/schemas/vertex_attribute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/edges/schemas/visibility.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"visibility": {
"type": "boolean"
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/points/schemas/color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"color": {
"type": "object",
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/points/schemas/size.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"size": {
"type": "number"
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_viewer/rpc/mesh/points/schemas/vertex_attribute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/points/schemas/visibility.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"visibility": {
"type": "boolean"
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/polygons/schemas/color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"color": {
"type": "object",
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_viewer/rpc/mesh/polygons/schemas/polygon_attribute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_viewer/rpc/mesh/polygons/schemas/vertex_attribute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/polygons/schemas/visibility.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"visibility": {
"type": "boolean"
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/polyhedrons/schemas/color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"color": {
"type": "object",
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_viewer/rpc/mesh/polyhedrons/schemas/polyhedron_attribute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_viewer/rpc/mesh/polyhedrons/schemas/vertex_attribute.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/polyhedrons/schemas/visibility.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"visibility": {
"type": "boolean"
Expand Down
11 changes: 7 additions & 4 deletions src/opengeodeweb_viewer/rpc/mesh/schemas/apply_textures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,21 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"textures": {
"type": "array",
"elements": {
"items": {
"type": "object",
"properties": {
"texture_name": {
"type": "string"
"type": "string",
"minLength": 1
},
"texture_file_name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
5 changes: 3 additions & 2 deletions src/opengeodeweb_viewer/rpc/mesh/schemas/color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"color": {
"type": "object",
"type": "object",
"properties": {
"r": {
"type": "integer",
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/schemas/deregister.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/schemas/opacity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"opacity": {
"type": "number",
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_viewer/rpc/mesh/schemas/register.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"file_name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/mesh/schemas/visibility.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"visibility": {
"type": "boolean"
Expand Down
9 changes: 6 additions & 3 deletions src/opengeodeweb_viewer/rpc/model/schemas/apply_textures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,21 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"textures": {
"type": "array",
"elements": {
"type": "object",
"properties": {
"texture_name": {
"type": "string"
"type": "string",
"minLength": 1
},
"texture_file_name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/model/schemas/deregister.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
6 changes: 4 additions & 2 deletions src/opengeodeweb_viewer/rpc/model/schemas/register.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"file_name": {
"type": "string"
"type": "string",
"minLength": 1
}
},
"required": [
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/model/schemas/set_components_color.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"color": {
"type": "object",
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/model/schemas/set_components_visibility.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"visibility": {
"type": "boolean"
Expand Down
3 changes: 2 additions & 1 deletion src/opengeodeweb_viewer/rpc/model/schemas/set_corners_size.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"type": "object",
"properties": {
"id": {
"type": "string"
"type": "string",
"minLength": 1
},
"size": {
"type": "integer"
Expand Down
Loading