Skip to content

Conversation

@MaxNumerique
Copy link
Contributor

…tabase

rm filename from register json schema
new functions for data_file_path get_data_info, get_data_file_path, load_data

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

mypy

🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]

def _init_ws(self):


🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "call" in typed context [no-untyped-call]

self.call("viewport.image.push.observer.add", [-1])


🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]

def _drain_initial_messages(self, max_messages: int = 5, timeout: float = 4.0):


🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation [no-untyped-def]

def _seed_database(session):


🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "_seed_database" in typed context [no-untyped-call]

_seed_database(session)


🚫 [mypy] reported by reviewdog 🐶
Untyped decorator makes function "dataset_factory" untyped [misc]


🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]

def _copy_asset(fname: str):


🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]


🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]

def initialize(self, database_path: str):


🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]


🚫 [mypy] reported by reviewdog 🐶
Function is missing a return type annotation [no-untyped-def]


🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "DatabaseManager" in typed context [no-untyped-call]


🚫 [mypy] reported by reviewdog 🐶
Module "src.opengeodeweb_viewer.database.connection" does not explicitly export attribute "Data" [attr-defined]

from .database.connection import db_manager, Data


🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation [no-untyped-def]


🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "get_session" in typed context [no-untyped-call]

session = db_manager.get_session()


🚫 [mypy] reported by reviewdog 🐶
Function is missing a type annotation [no-untyped-def]

def get_data_file_path(self, data_id, filename=None):


🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "get_data" in typed context [no-untyped-call]

data = self.get_data(data_id)


🚫 [mypy] reported by reviewdog 🐶
Argument 1 to "join" has incompatible type "str | None"; expected "str" [arg-type]

return os.path.join(self.DATA_FOLDER_PATH, data_id, filename)


🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "get_data_base" in typed context [no-untyped-call]

if id in self.get_data_base():


🚫 [mypy] reported by reviewdog 🐶
Call to untyped function "get_data_base" in typed context [no-untyped-call]

@BotellaA BotellaA merged commit ce39602 into next Oct 14, 2025
21 checks passed
@BotellaA BotellaA deleted the fix/database branch October 14, 2025 14:09
@JulienChampagnol
Copy link
Member

🎉 This PR is included in version 1.11.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants