Skip to content

CMakeLists changed#345

Closed
Anushkaagrawal22 wants to merge 3 commits intoGeomScale:developfrom
Anushkaagrawal22:develop
Closed

CMakeLists changed#345
Anushkaagrawal22 wants to merge 3 commits intoGeomScale:developfrom
Anushkaagrawal22:develop

Conversation

@Anushkaagrawal22
Copy link

No description provided.

@Anushkaagrawal22
Copy link
Author

This pull request is from my develop branch which is same as your develop branch plus the changes i have made. Can you please review.

Copy link

@vfisikop vfisikop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds CMAKE_MINIMUM_REQUIRED(VERSION 3.10) but there is CMAKE_MINIMUM_REQUIRED(VERSION 3.11) a few lines later in the file that should be removed.

@vfisikop vfisikop closed this Feb 14, 2025
@vfisikop vfisikop reopened this Feb 14, 2025
@Anushkaagrawal22
Copy link
Author

This PR adds CMAKE_MINIMUM_REQUIRED(VERSION 3.10) but there is CMAKE_MINIMUM_REQUIRED(VERSION 3.11) a few lines later in the file that should be removed.

I'll remove that CMAKE and will create pr again

@vissarion
Copy link
Member

No, please do not create more PRs! Just update this one.

@Anushkaagrawal22
Copy link
Author

No, please do not create more PRs! Just update this one.

okk

@vfisikop
Copy link

vfisikop commented Apr 9, 2025

Could you please update us on the status of this PR. What is the reason for changing the minimum required cmake version? Note that in the examples it is 3.11.

@Anushkaagrawal22
Copy link
Author

Could you please update us on the status of this PR. What is the reason for changing the minimum required cmake version? Note that in the examples it is 3.11.

Sir, i'll update the pr and change the version to 3.11

@vissarion vissarion closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants