Fix boolean semantics of HPolytope::is_in #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the return value semantics of
HPolytope::is_in().Currently,
is_in()returns-1for points that are inside the polytope and0for points that are outside. While this works for explicit comparisons(e.g.
is_in(p) == 0), it breaks natural boolean-style usage of the function,such as
if (is_in(p)), and can lead to silent logic errors.This change updates the function to return a positive value (
1) for insidepoints, while preserving
0for outside points. The function signature andoverall API remain unchanged, ensuring backward compatibility.
The fix restores expected predicate semantics without affecting existing code
that relies on explicit comparisons.
Closes #385