Update Torrent model with missing API fields#34
Merged
George-Miao merged 2 commits intoGeorge-Miao:masterfrom Aug 14, 2025
Merged
Update Torrent model with missing API fields#34George-Miao merged 2 commits intoGeorge-Miao:masterfrom
George-Miao merged 2 commits intoGeorge-Miao:masterfrom
Conversation
Owner
|
Would you please also update README with the comment in this PR? These undocumented fields may confuse users. |
Contributor
Author
|
Thanks for the feedback. I've updated README to reflect this. Does this look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the great work on this library. While using it, I found that the
Torrentmodel was missing several fields that are available in recent versions of the qBittorrent API.This PR addresses that by adding the following missing fields to the
Torrentstruct:commentdownload_pathhas_metadatainactive_seeding_time_limitinfohash_v1infohash_v2max_inactive_seeding_timepopularityprivatereannounceroot_pathtrackers_countIt's worth noting that the official qBittorrent API documentation appears to lag behind the API itself. This update is based on the actual JSON response from qBittorrent v5.1.2 and should bring the model up-to-date with what users will encounter in the wild.
Let me know if you have any feedback or require any changes.