Open
Conversation
Prior to this commit, if a device with more than eight channels appeared in a device list, only the first eight channels were actually displayed. Devices below the multi-channel device were not displayed. The issue relates to the naming of channels; they were given names depending on their channel number, which works well for up to eight channels. When the 9th channel appeared, it was considered to be Bar.NONE, which caused its name to be displayed in the center of the screen. Then, retreiving the name caused an exception, which caused the remaining devices not to be displayed. The solution is to give Bar.NONE a value that can't possibly be confused for a channel index, and to default to displaying the channel number if there is no name for the channel.
Prior to this commit, channel numbers were only displayed if there was no name for the channel, defined in Screen.SIDES. In reality, channels numbers don't necessarily correspond to a speaker function, e.g. in a music studio context. Then it's more useful to know the actual channel number. With this commit, channel numbers are always displayed, with the speaker side name displayed if available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements