Skip to content

Dem_s update in connectivity function call#106

Merged
robbibt merged 5 commits intodevelopfrom
dem_update
Mar 17, 2025
Merged

Dem_s update in connectivity function call#106
robbibt merged 5 commits intodevelopfrom
dem_update

Conversation

@erialC-P
Copy link
Collaborator

This PR replaces the hydrological SRTM dem layer (dem_h) with the smoothed raw SRTM dem (dem_s) in our connectivity masking function call. The PR swaps the default value in the function call from dem_h to dem_s and updates the explicit use of the function in the intertidal_workflow notebook.
Both layers handle nodata values differently but I have confirmed that the difference does not impact the outputs in the connectivity masking function (figure 1).
image
This figure details the resulting connectivity masks, calculated using a) dem_h, b) dem_s (applied as per (a), where nodata values form the starting point for the cost-distance mask), d) dem_s, where 0 m elevations are used as the base of the cost-distance mask and c) the (null) difference between (b) and (d), showing that our code produces the same outcomes, regardless of the nodata or 0 m elevation baseline. Consequently, our extents.load_connectivity_mask function call has not been changed to accommodate the new dem input layer.

@robbibt robbibt self-requested a review March 17, 2025 01:37
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @erialC-P! I reverted the change to the tests (see comment), but apart from that, looks great!

@robbibt robbibt merged commit ff6ab8c into develop Mar 17, 2025
1 check failed
@erialC-P erialC-P deleted the dem_update branch March 17, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants