Skip to content

extents and CLI updates#110

Merged
robbibt merged 19 commits intodevelopfrom
extents_update
Apr 8, 2025
Merged

extents and CLI updates#110
robbibt merged 19 commits intodevelopfrom
extents_update

Conversation

@erialC-P
Copy link
Collaborator

@erialC-P erialC-P commented Apr 3, 2025

This PR makes three updates:

  1. updates extents.py 'load_connectivity_mask' to create a cost-distance coastal mask using the nodata values from dem_h in SRTM as start values and elevations from dem_s layer as costs values
  2. edit the inland water class in the extents func to revert to ocean and coastal water class if it is connected to the coastal mask
  3. change the 'load_connectivity_mask' defaults in CLI to apply mangroves and HAT to the cost-distance coastal mask

Additional changes from Robbi:

Major changes:

  • Updated default connectivity mask threshold from 100 to 50 (need to test this)
  • Added coastal connectivity mask to new qa_coastal_mask QA layer
  • Updated workflow to use new GMW mangrove extents layer
  • Changed dask chunking from {"x": 1600, "y": 1600} to {"x": 3200, "y": 3200} to improve data loading

Minor changes:

  • Simplifed extents code to apply class_connection directly to mostly_wet layer
  • Updated Python packaging to use DEA package version of hdstats to ensure proper thread parallelisation
  • Made geomedian eps parameter configurable via the CLI

…n extents and connectivity mask defaults in CLI
@erialC-P erialC-P requested review from robbibt and vnewey April 3, 2025 05:23
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

For full integration test results, refer to the Tests directory README.

@robbibt
Copy link
Member

robbibt commented Apr 8, 2025

Have made some additional changes to this PR:

Major changes:

  • Updated default connectivity mask threshold from 100 to 50 (need to test this)
  • Added coastal connectivity mask to new qa_coastal_mask QA layer
  • Updated workflow to use new GMW mangrove extents layer
  • Changed dask chunking from {"x": 1600, "y": 1600} to {"x": 3200, "y": 3200} to improve data loading

Minor changes:

  • Simplifed extents code to apply class_connection directly to mostly_wet layer
  • Updated Python packaging to use DEA package version of hdstats to ensure proper thread parallelisation
  • Made geomedian eps parameter configurable via the CLI

@robbibt robbibt merged commit 39c4188 into develop Apr 8, 2025
@robbibt robbibt deleted the extents_update branch April 10, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants