Merged
Conversation
uses eo-tides removes sunglint io updated to work for composites thumbnail changed for composites in io.py
added tidal_composites_cli as an entry point in setup.py, so we can call it from the docker image
Now uses only valid obs to calculate the low and high tide quantiles. Renamed product tidal composites. export bands low_threshold and high_threshold
changes to io.py for use with composites
|
For full integration test results, refer to the Tests directory README. |
robbibt
approved these changes
Apr 7, 2025
Member
There was a problem hiding this comment.
Awesome work @vnewey!
I made a few changes:
- Refactored the composite code to load less data (only one band is fully loaded into memory, with other bands only loaded for the low and high tide timesteps of interest)
- Switched to
xr_quantileinstead of.quantile() - Updated the metadata document to add aliases and change order of bands
- Moved sunglint masking logic into
load_data - Removed
count_clearoutput (keeping only low and high tide counts) - Updated some documentation and function params to match Intertidal
Overall this produces a speedup on 8XL:
Original:
Wall time: 33min
Updated:
Wall time: 15min 33s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of composites
io updated to work for composites
updated Intertidal_CLI notebook for both intertidal and tidal composites