Fix change in xarray that requires .item() to be called on max()#141
Closed
alexgleith wants to merge 1 commit intoGeoscienceAustralia:developfrom
Closed
Fix change in xarray that requires .item() to be called on max()#141alexgleith wants to merge 1 commit intoGeoscienceAustralia:developfrom
alexgleith wants to merge 1 commit intoGeoscienceAustralia:developfrom
Conversation
robbibt
reviewed
Jul 31, 2025
alexgleith
force-pushed
the
fix-xarray-change
branch
from
d517b7e to
955ef1d
Compare
Member
|
This looks fine to me... I would like to be able to run the tests, but for some reason they are failing with credential issues (even though they don't for me or for Matt's external PRs). Might just need to merge this and then let the tests run later (and roll back if there are any issues) |
Collaborator
Author
|
Must be because I'm doing the PR from external. How about you reject it and I'll create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for newer versions of xarray, I'm assuming.
Was getting an exception without this.
Also, without using newer eodatasets, other things were failing, something about LocalConfig.