Support external tide data, upgrade DEA Tools #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For full integration test results, refer to the Tests directory README. |
This was
linked to
issues
Oct 21, 2025
erialC-P
approved these changes
Oct 22, 2025
Collaborator
erialC-P
left a comment
erialC-P
left a comment
There was a problem hiding this comment.
Hey Robbi, this is a great addition to the repo! The changes all look good to me and I like the notebook to demonstrate the approach. Super happy to approve! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
tide_dataparameter to theelevationfunction to allow users to pass in external time series data instead of modelling tides (e.g. observed tide gauge data, or the outputs of local hydrodynamic modelling).See example usage notebook here:
https://github.com/GeoscienceAustralia/dea-intertidal/blob/external_tides/notebooks/Intertidal_elevation_from_external_sea_level_data.ipynb