Skip to content

Update DEA Intertidal to use eo-tides#99

Merged
vnewey merged 17 commits intodevelopfrom
eo_tides
Feb 17, 2025
Merged

Update DEA Intertidal to use eo-tides#99
vnewey merged 17 commits intodevelopfrom
eo_tides

Conversation

@robbibt
Copy link
Member

@robbibt robbibt commented Feb 13, 2025

Updates repo to use eo-tides instead of DEA Tools:

  • Updated Python packaging to use eo-tides
  • Switched to eo-tides version of pixel_tides function
  • Switched default model to EOT20 (instead of FES2014) to match eo-tides default
  • Updated documentation and removed some outdated/unused code (e.g. export_intertidal_rasters, tidal_offset_tidelines, pixel_ebb_flow)

Annoyingly I have commited some extra code I was working on a while ago, to add spearman correlation as an alternative tide correlation method (it should have been in a different PR to keep this one easier to review!). It's mainly in the spearman_correlation and a little bit in ds_to_flat.

@github-actions
Copy link

For full integration test results, refer to the Tests directory README.

@robbibt robbibt marked this pull request as ready for review February 14, 2025 02:00
@robbibt robbibt requested review from erialC-P and vnewey February 14, 2025 02:03
Copy link
Collaborator

@vnewey vnewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Robbi.

Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't loaded and run the code but it all looks good in the github codespace!

@vnewey vnewey merged commit bfacc27 into develop Feb 17, 2025
@robbibt robbibt deleted the eo_tides branch April 7, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants