Conversation
|
For full integration test results, refer to the Tests directory README. |
erialC-P
approved these changes
Feb 14, 2025
Collaborator
erialC-P
left a comment
There was a problem hiding this comment.
I haven't loaded and run the code but it all looks good in the github codespace!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Updates repo to use
eo-tidesinstead of DEA Tools:eo-tideseo-tidesversion ofpixel_tidesfunctionEOT20(instead of FES2014) to matcheo-tidesdefaultexport_intertidal_rasters,tidal_offset_tidelines,pixel_ebb_flow)Annoyingly I have commited some extra code I was working on a while ago, to add spearman correlation as an alternative tide correlation method (it should have been in a different PR to keep this one easier to review!). It's mainly in the
spearman_correlationand a little bit inds_to_flat.