-
Notifications
You must be signed in to change notification settings - Fork 136
Update downloading STAC notebook #1451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop_stac
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -4,27 +4,59 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. import odc.aws
Well that's cool - I didn't know odc had an aws module.
Is it worth having links to the docs pages for these modules in the notebook? Not necessarily here in the load cell, but where they are used later down in the notebook.
AWS — Open Data Cube 1.9.12.dev19+g3f6a0c018 documentation
Reply via ReviewNB
| @@ -4,27 +4,59 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use blue call-out box from the template to make this really jump out to the user maybe?
Reply via ReviewNB
| @@ -4,27 +4,59 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure what is happening with the formatting here:
# Get list of all URLs for the 'nbart_blue' band asset = 'nbart_blue' urls = [i.assets["nbart_blue"].href for i in items]
Is the "get list" part meant to be a subtitle and then the code is meant to be inside `?
Reply via ReviewNB
load()andconfigure_s3_accessimportedpystac_clientClientimportedcatalog,stac_clientandconfigure_s3_access()pystac-clientodc-stacdatacubesys.path.insert(1, '../Tools/')