NPI-4443 Clean up unit test outputs and temporarily pin supported Pandas version #108
Merged
NPI-4443 Clean up unit test outputs and temporarily pin supported Pandas version #108
Conversation
…cessing, to aid unit test design
… terminal. This clean up will support work to fix Pandas 3 compatibility issues. While these issues are worked through, the last compatible version of pandas (2.3.3) is pinned.
…t print them in unittests
… print them in unittests
… in warnings, to make unit tests deterministic
… warning messages
…remove a redundant error log
ronaldmaj
approved these changes
Jan 30, 2026
Collaborator
ronaldmaj
left a comment
ronaldmaj
left a comment
There was a problem hiding this comment.
This looks good to me - a good clean-up of warnings and pinning Pandas to a version we know will not have issues with the current state of the codebase.
When running the unit tests, it seems to complete fine. I did get the folloiwng Errors when running though:
python -m unittest
.......................2026-01-30 04:48:54,498 [download_file_from_cddis] ERROR: Failed to download test.txt after 0 retries: Connection timeout
...2026-01-30 04:48:54,504 [download_file_from_cddis] ERROR: Failed to download test.txt after 0 retries: 404 Client Error: Not Found
..............................................................
----------------------------------------------------------------------
Ran 88 tests in 2.791s
OK
Collaborator
Author
|
Those download errors appear to be the intention of their respective tests. I haven't looked into checking and excluding them from output, as I did with the warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pandasto2.3.3as a temporary measure while investigating compatibility issues when using Pandas 3.