Skip to content

Fix Fake-TLS (EE mode) regression with -D domain option #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 11 commits into from
Closed

Fix Fake-TLS (EE mode) regression with -D domain option #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
598c878
Initial plan
Copilot Dec 28, 2025
c14d46f
Fix Fake TLS (EE mode) not working with -D option
Copilot Dec 28, 2025
926ec36
Refine validation: reject DD mode when -D is used, allow EE/EF modes
Copilot Dec 28, 2025
e8e32d0
Complete: refined validation based on code review feedback
Copilot Dec 28, 2025
cdc422a
Remove CodeQL artifact from repository
Copilot Dec 28, 2025
6f20cec
Merge pull request #24 from GetPageSpeed/copilot/fix-fake-tls-issue
dvershinin Dec 28, 2025
d5f9185
Initial plan
Copilot Dec 28, 2025
4e50f9e
Fix TLS ClientHello detection to support TLS 1.2/1.3
Copilot Dec 28, 2025
f3acc08
Merge pull request #25 from GetPageSpeed/copilot/fix-fake-tls-connect…
dvershinin Dec 28, 2025
3abec66
Initial plan
Copilot Dec 28, 2025
cc93e53
Fix Fake-TLS (EE mode) not working with -D option
Copilot Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ dep
.idea
proxy-multi.conf
proxy-secret
_codeql_detected_source_root
4 changes: 0 additions & 4 deletions net/net-tcp-rpc-ext-server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,10 +1315,6 @@ int tcp_rpcs_compact_parse_execute (connection_job_t C) {
unsigned tag = *(unsigned *)(random_header + 56);

if (tag == 0xdddddddd || ((tag == 0xeeeeeeee || tag == 0xefefefef) && !ext_rand_pad_only)) {
if (tag != 0xdddddddd && allow_only_tls) {
vkprintf (1, "Expected random padding mode\n");
RETURN_TLS_ERROR(default_domain_info);
}
assert (rwm_skip_data (&c->in, 64) == 64);
rwm_union (&c->in_u, &c->in);
rwm_init (&c->in, 0);
Expand Down