Skip to content

[VID-344]: Add metadata to rtmp ingress (software, location etc) #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
su225 merged 2 commits into from
Feb 12, 2025
Merged

[VID-344]: Add metadata to rtmp ingress (software, location etc) #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49d1b2a
Add RTMPIngress protobuf model for RTMP stream metadata
sachaarbonel Feb 12, 2025
3e8127e
Add RTMP ingress support to SendStatsRequest protobuf + makefile comm…
sachaarbonel Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,19 @@ CURRENT_VERSION_BUG = 0
GIT_DESCRIBE := $(shell git describe)
GITHUB_HEAD_REF ?= $(shell git branch --show-current)

.PHONY: install-proto-tools
install-proto-tools:
@echo "Installing protobuf tools..."
./install.sh

.PHONY: generate-proto
generate-proto:
@echo "Generating protocol buffers..."
REALPATH=grealpath ./generate.sh

.PHONY: proto
proto: install-proto-tools generate-proto

update-main:
git checkout main
git pull
Expand Down
672 changes: 398 additions & 274 deletions protobuf/video/sfu/models/models.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 15 additions & 0 deletions protobuf/video/sfu/models/models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,21 @@ message Browser {
string version = 2;
}

message RTMPIngress {
// Video dimensions and frame rate
uint32 width = 1;
uint32 height = 2;
double frame_rate = 3;

// Client info
string software = 4; // e.g. "obs-studio"
string version = 5; // e.g. "29.1.3"
string encoder = 6; // e.g. "x264" or "NVIDIA NVENC"

// Connection info
string remote_addr = 7;
}

message Device {
string name = 1;
string version = 2;
Expand Down
Loading