-
Notifications
You must be signed in to change notification settings - Fork 0
Update publish-release job to publish docs as GH pages #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update publish-release job to publish docs as GH pages #10
Conversation
WalkthroughThe release workflow now automatically generates Dokka HTML documentation and publishes it to GitHub Pages during the release process. The Gradle build configuration has been updated to include the Dokka plugin alongside other build tools, with plugin declarations refactored to use aliases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
.github/workflows/release.ymlbuild.gradle.ktsplugin/src/main/kotlin/io/getstream/android/StreamConventionPlugins.ktplugin/src/main/kotlin/io/getstream/android/publishing/PublishingConfiguration.kt
🧰 Additional context used
🧬 Code graph analysis (1)
plugin/src/main/kotlin/io/getstream/android/StreamConventionPlugins.kt (1)
plugin/src/main/kotlin/io/getstream/android/publishing/PublishingConfiguration.kt (2)
configurePublishingRoot(39-41)configurePublishingModule(43-66)
🪛 actionlint (1.7.9)
.github/workflows/release.yml
155-155: property "stream_public_bot_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; github-token: string; github_token: string; maven-central-password: string; maven-central-username: string; signing-key: string; signing-key-id: string; signing-key-password: string}
(expression)
🔇 Additional comments (5)
build.gradle.kts (1)
3-6: LGTM! Clean migration to version catalog aliases.The changes properly use plugin aliases and integrate Dokka at the root level for multi-module documentation generation.
.github/workflows/release.yml (1)
149-150: LGTM! Dokka generation step is correctly configured.The step properly invokes the Dokka multi-module HTML generation task.
plugin/src/main/kotlin/io/getstream/android/publishing/PublishingConfiguration.kt (2)
39-41: LGTM! Clean separation of root-level publishing concerns.The function properly applies Dokka at the root level for multi-module documentation generation.
43-66: Remove this comment—the Dokka plugin applications are correctly scoped to different projects.The Dokka plugin is applied to the root project in
configurePublishingRoot()and to individual modules inconfigurePublishingModule(). These are separateProjectinstances, not duplicates applied to the same project. The root-level application supports multi-module documentation generation, while module-level application enables individualdokkaJavadoctasks required for publishing artifacts. No conflicts or issues result from this pattern.Likely an incorrect or invalid review comment.
plugin/src/main/kotlin/io/getstream/android/StreamConventionPlugins.kt (1)
23-24: LGTM! Clean separation of root and module publishing configuration.The changes correctly apply:
configurePublishingRoot()in the root convention plugin (Line 42)configurePublishingModule()in all module convention plugins (Lines 69, 95, 108)This properly separates root-level concerns (multi-module Dokka setup) from module-level concerns (individual module publishing).
Also applies to: 42-42, 69-69, 95-95, 108-108
081d557 to
c4d8853
Compare
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.