Skip to content

Conversation

@gpunto
Copy link
Collaborator

@gpunto gpunto commented Nov 7, 2025

No description provided.

@gpunto gpunto requested a review from Copilot November 7, 2025 14:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Maven publishing configuration support to the Stream build conventions plugin, enabling automatic publishing for library and platform modules.

  • Introduces new publishing configuration with customizable artifact IDs and descriptions
  • Adds a new Java platform convention plugin (io.getstream.java.platform)
  • Refactors the findOrRegister utility function to a shared location for reuse

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
plugin/src/main/kotlin/io/getstream/android/publishing/PublishingOptions.kt New configuration class defining publishing options with description and artifact ID overrides
plugin/src/main/kotlin/io/getstream/android/publishing/PublishingConfiguration.kt Core publishing logic integrating vanniktech maven-publish plugin with Dokka for documentation
plugin/src/main/kotlin/io/getstream/android/GradleUtils.kt Extracted findOrRegister utility function for shared task registration logic
plugin/src/main/kotlin/io/getstream/android/spotless/SpotlessConfiguration.kt Refactored to import findOrRegister from shared utilities instead of local definition
plugin/src/main/kotlin/io/getstream/android/StreamConventionPlugins.kt Added JavaPlatformConventionPlugin and integrated publishing into library plugins
plugin/src/main/kotlin/io/getstream/android/StreamConventionExtensions.kt Extended project configuration with publishing options
plugin/build.gradle.kts Added maven-publish and dokka plugin dependencies, registered new Java platform plugin
gradle/libs.versions.toml Added maven-publish and dokka library references, removed unused gradle-plugin-publish
README.md Updated documentation with publishing configuration examples and versioning instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gpunto gpunto force-pushed the publishing branch 2 times, most recently from f6db8b1 to effbeaa Compare November 7, 2025 14:42
@gpunto gpunto force-pushed the publishing branch 2 times, most recently from a839105 to cf7709c Compare December 15, 2025 13:14
@gpunto gpunto marked this pull request as ready for review December 15, 2025 13:53
uses: actions/checkout@v4
with:
token: ${{ secrets.github-token }}
ref: develop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't necessarily want to checkout from develop when publishing a snapshot.

detekt = "1.23.8"
spotless = "8.0.0"
kotlinDokka = "2.0.0"
kotlinDokka = "1.9.20"
Copy link
Collaborator Author

@gpunto gpunto Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading for the time being, because I don't want to bundle all the changes for the migration to the publishing configuration with the changes needed for migrating to Dokka v2 in products. I'll do the upgrade later.

@gpunto gpunto requested a review from a team December 15, 2025 14:53
@aleksandar-apostolov aleksandar-apostolov merged commit 7e85a31 into develop Dec 16, 2025
6 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the publishing branch December 16, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants