-
Notifications
You must be signed in to change notification settings - Fork 0
Add publishing configuration to plugins #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Maven publishing configuration support to the Stream build conventions plugin, enabling automatic publishing for library and platform modules.
- Introduces new publishing configuration with customizable artifact IDs and descriptions
- Adds a new Java platform convention plugin (
io.getstream.java.platform) - Refactors the
findOrRegisterutility function to a shared location for reuse
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugin/src/main/kotlin/io/getstream/android/publishing/PublishingOptions.kt | New configuration class defining publishing options with description and artifact ID overrides |
| plugin/src/main/kotlin/io/getstream/android/publishing/PublishingConfiguration.kt | Core publishing logic integrating vanniktech maven-publish plugin with Dokka for documentation |
| plugin/src/main/kotlin/io/getstream/android/GradleUtils.kt | Extracted findOrRegister utility function for shared task registration logic |
| plugin/src/main/kotlin/io/getstream/android/spotless/SpotlessConfiguration.kt | Refactored to import findOrRegister from shared utilities instead of local definition |
| plugin/src/main/kotlin/io/getstream/android/StreamConventionPlugins.kt | Added JavaPlatformConventionPlugin and integrated publishing into library plugins |
| plugin/src/main/kotlin/io/getstream/android/StreamConventionExtensions.kt | Extended project configuration with publishing options |
| plugin/build.gradle.kts | Added maven-publish and dokka plugin dependencies, registered new Java platform plugin |
| gradle/libs.versions.toml | Added maven-publish and dokka library references, removed unused gradle-plugin-publish |
| README.md | Updated documentation with publishing configuration examples and versioning instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugin/src/main/kotlin/io/getstream/android/publishing/PublishingOptions.kt
Outdated
Show resolved
Hide resolved
f6db8b1 to
effbeaa
Compare
a839105 to
cf7709c
Compare
| uses: actions/checkout@v4 | ||
| with: | ||
| token: ${{ secrets.github-token }} | ||
| ref: develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't necessarily want to checkout from develop when publishing a snapshot.
| detekt = "1.23.8" | ||
| spotless = "8.0.0" | ||
| kotlinDokka = "2.0.0" | ||
| kotlinDokka = "1.9.20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgrading for the time being, because I don't want to bundle all the changes for the migration to the publishing configuration with the changes needed for migrating to Dokka v2 in products. I'll do the upgrade later.
No description provided.