Add automatic snapshot publishing #6
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds automatic snapshot publishing triggered on pushes to the develop branch while simplifying the manual release workflow by removing snapshot-specific input parameters.
- Creates a new automatic snapshot workflow that triggers on pushes to
develop - Removes
snapshot,version-properties-fileinputs from the manual publish workflow - Separates snapshot publishing from manual version releases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/publish-snapshot.yml |
New workflow for automatic snapshot builds triggered on develop branch pushes |
.github/workflows/publish-new-version.yml |
Removes snapshot-related inputs, focusing on manual version releases only |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gpunto
force-pushed
the
publish-snapshots-on-develop
branch
from
8fbc6ac to
e0b934d
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| push: false | ||
|
|
||
| - name: Push changes to ci-release branch | ||
| if: ${{ !inputs.snapshot }} |
There was a problem hiding this comment.
Took the opportunity to completely split snapshot and final release publishing. I think it's less error prone this way, as we now have two separate jobs instead of one job with excluded steps.
I also considered splitting the workflow into two files, but discarded that approach because I find it clearer to see the publishing in one place, so you don't have to know that two workflows exist.
| - minor | ||
| - major | ||
| default: minor | ||
| version-properties-file: |
There was a problem hiding this comment.
We just rely on the defaults (also, the idea is to align all SDKs to use the same mechanisms, so nobody will have to specify the version properties file).
VelikovPetar
left a comment
VelikovPetar
left a comment
There was a problem hiding this comment.
LGTM!
Probably would be good to have an approval from someone from video as well!
Adding automatic snapshot publishing on commits on develop, like we do it in Chat and Video. It's also a good opportunity to test this workflow here before changing Chat and Video to use the common one in this repository.