-
Notifications
You must be signed in to change notification settings - Fork 373
feat(ui, localization): add support for async audio #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17c0998 to
46f4f64
Compare
…le_attachment.dart
renefloor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found some issues on Android.
First of all, it would not compile. It was complaining about sealed classes. I had to add this to the settings.gradle of the example app:
pluginManagement {
buildscript {
repositories {
mavenCentral()
maven {
url = uri("https://storage.googleapis.com/r8-releases/raw")
}
}
dependencies {
classpath("com.android.tools:r8:8.2.24")
}
}
}From: https://issuetracker.google.com/issues/227160052#comment37
We should definitely document this somewhere, probably in the changelog. I think that's going to effect (almost) every user.
Second (in the example) I have an issue with the permission dialog.
After I give permission my finger is no longer on the record button, but the app thinks it is. There is no way to stop the recording. It does actually happen more often, also when there is no permission dialog in between.
screen-20250207-102626.mp4
When I do manage to get a recording I cannot listen to it. The file does not exist:
Caused by: java.io.FileNotFoundException: /data/user/0/com.example.example/cache/audio_1738920852258.m4a: open failed: ENOENT (No such file or directory)
screen-20250207-102511.mp4
should be fixed now |
This pull request includes several changes to the
melos.yamlfile, improvements to theAttachmentFileclass in thestream_chatpackage, and updates to thestream_chat_flutterpackage to enhance voice recording features and deprecate older classes.Dependency Updates:
recorddependency tomelos.yaml.path_provider_platform_interfaceandplugin_platform_interfacedependencies tomelos.yaml.AttachmentFileClass Improvements:namegetter to use pattern matching for better readability.toMultipartFilemethod to use aswitchstatement for platform-specific logic.UploadStateand other related classes to use thesealedkeyword for better type safety. [1] [2] [3] [4] [5]Voice Recording Enhancements:
StreamMessageInputonChannelPageandThreadPage. [1] [2]record_linuxandrecord_windowsplugins to the generated plugin lists. [1] [2]VoiceRecordingAttachmentPlaylistBuilderand updatedMixedAttachmentBuilderto handle voice recordings. [1] [2] [3] [4] [5] [6]Deprecated Classes:
stream_chat_flutterin favor of new implementations. [1] [2] [3] [4] [5] [6] [7] [8] [9]Screen.Recording.2025-02-06.at.00.12.22.mov