fix(search): missing thread_participants in message#1412
Merged
Conversation
kanat
requested review from
MartinCupela,
arnautov-anton,
khushal87,
myandrienko,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
Contributor
|
Size Change: 0 B Total Size: 461 kB ℹ️ View Unchanged
|
kanat
changed the title
oliverlaz
approved these changes
Dec 9, 2024
| } | ||
| >; | ||
|
|
||
| export type MessageOptions = { |
Contributor
There was a problem hiding this comment.
I think that only MessageOptions would not be clear enough to convey the fact that these are actually search payload options.
Suggested change
| export type MessageOptions = { | |
| export type SearchMessageOptions = { |
Contributor
Author
There was a problem hiding this comment.
Yeah I thought about it as well, however, technically, in the future, it could be used in other places where the MessageFilters is also used.
kanat
force-pushed
the
fix/search-thread-participants
branch
from
6c9d0dc to
7102756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Related PR
Summary
Enable the
Channel.searchto enrichthread_participantsin found messages.CLA
Changelog