fix: export promoteChannel #1474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuperaz
requested review from
MartinCupela,
arnautov-anton,
khushal87,
myandrienko,
oliverlaz,
santhoshvai and
vishalnarkhede
as code owners
Contributor
|
Size Change: +51 B (+0.01%) Total Size: 525 kB
|
isekovanic
approved these changes
Feb 27, 2025
isekovanic
reviewed
Feb 27, 2025
| export * from './types'; | ||
| export * from './channel_manager'; | ||
| export { isOwnUser, chatCodes, logChatPromiseExecution, formatMessage } from './utils'; | ||
| export { isOwnUser, chatCodes, logChatPromiseExecution, formatMessage, promoteChannel } from './utils'; |
Contributor
There was a problem hiding this comment.
At some point, we should probably also export our other utils that might be useful for this; I was under the impression that all of them are exported (or at least the heavily tested ones).
Thoughts on this ? I can open a PR for it later
Merged
arnautov-anton
pushed a commit
that referenced
this pull request
Feb 27, 2025
# 🚀 v8.57.2 Make sure to use squash & merge when merging! Once this is merged, another job will kick off automatically and publish the package. # 📝 Changelog ## [8.57.2](v8.57.1...v8.57.2) (2025-02-27) ### Bug Fixes * export promoteChannel ([#1474](#1474)) ([f2ba914](f2ba914)) # Co-authored-by: github-actions <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2025
## [9.0.0-rc.3](v9.0.0-rc.2...v9.0.0-rc.3) (2025-02-27) ### Bug Fixes * export promoteChannel ([#1474](#1474)) ([f2ba914](f2ba914))
|
🎉 This PR is included in version 9.0.0-rc.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Angular SDK needs to
setChannelsin case ofaddChannel,removeChannelmethodsChangelog