-
Notifications
You must be signed in to change notification settings - Fork 78
feat: add deleted_for_me field in message response #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add deleted_for_me field in message response #1604
Conversation
|
Size Change: +979 B (+0.29%) Total Size: 338 kB
|
|
@daksh-r if I understand it well, we still need to update for the user that deleted it for himself: What will be the |
|
I also see that we will need to update the |
|
@daksh-r why the WS event has the following format: but the message object will contain Isn't that duplication? Is it necessary to have |
in the ws event, we don't send |
we only add the |
| connection_id?: string; | ||
| // event creation timestamp, format Date ISO string | ||
| created_at?: string; | ||
| deleted_for_me?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to add this property to the WS event payload root if it is already contained inside the message object? I suppose that this would be message.deleted event that carries the message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that I already pointed this out and see that the message inside the WS event is not getting the property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the property has been added recently, can you tell for which request you aren't receiving this ?
you can find the latest sdk spec here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no big deal
…in client.deleteMessage
1365dc0 to
b2df356
Compare
|
🎉 This PR is included in version 9.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Goal
handle delete-for-me scenario in messages:
client.deleteMessage()methodtype'deleted'anddeleted_for_meboolean flag