Skip to content

fix(bundle): define separate externals (browser/Node) #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnautov-anton merged 1 commit into from
Oct 10, 2025
Merged

fix(bundle): define separate externals (browser/Node) #1634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions scripts/bundle.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env node

import { resolve } from 'node:path';
import { builtinModules } from 'node:module';
import * as esbuild from 'esbuild';
import packageJson from '../package.json' with { type: 'json' };
import getPackageVersion from './get-package-version.mjs';
Expand All @@ -12,11 +13,20 @@ const watchModeEnabled = process.argv.includes('--watch') || process.argv.includ

const version = getPackageVersion();

const external = Object.keys({
const modules = Object.keys({
...packageJson.dependencies,
...packageJson.peerDependencies,
});

// do not externalize modules that are ignored in browser field
// externalizing them will cause esbuild to not replace the imports
// in the bundles
const browserIgnoreModules = Object.keys(packageJson.browser);
const browserExternal = modules.filter(
(module) => !browserIgnoreModules.includes(module),
);
const nodeExternal = [...modules, ...builtinModules];

/** @type esbuild.BuildOptions */
const commonBuildOptions = {
entryPoints: [resolve(__dirname, '../src/index.ts')],
Expand Down Expand Up @@ -44,7 +54,7 @@ const bundles = [
['browser', 'node'].map((platform) => ({
...commonBuildOptions,
format: 'cjs',
external,
external: platform === 'browser' ? browserExternal : nodeExternal,
entryNames: `[dir]/[name].${platform}`,
outdir: resolve(__dirname, '../dist/cjs'),
platform,
Expand All @@ -57,7 +67,7 @@ const bundles = [
{
...commonBuildOptions,
format: 'esm',
external,
external: browserExternal,
outExtension: { '.js': '.mjs' },
outdir: resolve(__dirname, '../dist/esm'),
entryNames: `[dir]/[name]`,
Expand Down
Loading