Skip to content

refactor: make channel and client protected in CommandSearchSource and MentionsSearchSource #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinCupela merged 1 commit into from
Oct 14, 2025
Merged

refactor: make channel and client protected in CommandSearchSource and MentionsSearchSource #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/messageComposer/middleware/textComposer/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import type { TextComposerMiddlewareExecutorState } from './TextComposerMiddlewa

export class CommandSearchSource extends BaseSearchSourceSync<CommandSuggestion> {
readonly type = 'commands';
private channel: Channel;
protected channel: Channel;

constructor(channel: Channel, options?: SearchSourceOptions) {
super(options);
Expand Down
4 changes: 2 additions & 2 deletions src/messageComposer/middleware/textComposer/mentions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ export type MentionsSearchSourceOptions = SearchSourceOptions & {

export class MentionsSearchSource extends BaseSearchSource<UserSuggestion> {
readonly type = 'mentions';
private client: StreamChat;
private channel: Channel;
protected client: StreamChat;
protected channel: Channel;
userFilters: UserFilters | undefined;
memberFilters: MemberFilters | undefined;
userSort: UserSort | undefined;
Expand Down