fix: prevent search source pagination on non-retryable response errors #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
requested review from
arnautov-anton,
isekovanic,
khushal87,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
Contributor
|
Size Change: +265 B (+0.07%) Total Size: 354 kB
|
oliverlaz
reviewed
Oct 14, 2025
src/search/ChannelSearchSource.ts
Outdated
Comment on lines
79
to
93
| protected isFatalError = (error: Error) => { | ||
| // unwrapping error message that has been wrapped | ||
| // 1. server-side once - /.*failed with error: "(.*)"/ | ||
| // 2. client-side second time - StreamChat error code \d+: | ||
| const originalErrorString = error.message.match( | ||
| /StreamChat error code \d+: .*failed with error: "(.*)"/, | ||
| )?.[1]; | ||
| if (!originalErrorString) return false; | ||
| try { | ||
| const originalError = JSON.parse(originalErrorString) as APIErrorResponse; | ||
| return /field is empty or contains invalid characters/.test(originalError.message); | ||
| } catch (e) { | ||
| return false; | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
This implementation is quite heuristic. Maybe extend this list with fatal/non-fatal information?
…earch source pagination
MartinCupela
changed the title
oliverlaz
approved these changes
Oct 23, 2025
|
🎉 This PR is included in version 9.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Closes React-607
Prevent repeating queries with a search string that will always end up in API error response. By default errors are not considered reason to switch
hasNextflag tofalse. Non-retryable errors should however lead to that.Example:
Infinite scroll pagination repeating requests with the same search string that causes the error. Leads to infinite loop.