chore: make imageContainerStyle theme compliant#2950
Merged
isekovanic merged 1 commit intodevelopfrom Feb 17, 2025
Merged
Conversation
Contributor
SDK Size
|
This was referenced Feb 13, 2025
khushal87
approved these changes
Feb 17, 2025
Contributor
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
It appears that in some integrations our
Gallerycomponent withinMessageListwas behaving weirdly.Although this was not reproducible (for me at least) on our:
Exposample appExpoapplicationit is explained in detail in this Github issue.
Regardless, exposing
imageContainerStylewithin ourthemesystem should allow these properties to be overridden and unset from the styles if needed.Many thanks to @prassamin for this PR and for tracking down the origin of the issue.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch