fix: change flatlist inside the bottom sheet modal and fix gesture in bottom sheet#2953
Merged
fix: change flatlist inside the bottom sheet modal and fix gesture in bottom sheet#2953
Conversation
Contributor
SDK Size
|
isekovanic
reviewed
Feb 17, 2025
isekovanic
reviewed
Feb 18, 2025
isekovanic
approved these changes
Feb 18, 2025
Contributor
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to make the FlatList/ScrollView responsive inside the BottomSheetModal. We were using the one from React native, which was not working with the gesture handler, so we migrated it to the one from
react-native-gesture-handler.As a part of the PR, the bottom sheet is also improved, and the pan gesture reacts to the gesture we put in the UI.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-17.at.20.24.38.mp4