fix: improve channel preview display hooks and long title issue#3002
Merged
fix: improve channel preview display hooks and long title issue#3002
Conversation
Contributor
SDK Size
|
isekovanic
reviewed
Mar 10, 2025
package/src/components/ChannelPreview/hooks/useChannelPreviewDisplayPresence.ts
Outdated
Show resolved
Hide resolved
isekovanic
reviewed
Mar 10, 2025
isekovanic
reviewed
Mar 10, 2025
package/src/components/ChannelPreview/hooks/useChannelPreviewDisplayName.ts
Outdated
Show resolved
Hide resolved
isekovanic
approved these changes
Mar 11, 2025
Contributor
|
🎉 This PR is included in version 6.6.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to improve the channel preview display hooks to use
useMemoinstead of a combination ofuseStateanduseEffectfor the calculation that would take an additional render.Also, the title logic for the channel preview is improved for channels that have long names. This was a UI issue that was easily noticeable and looked bad.
I am open to discussion if anything doesn't seem correct here.
Linear - https://linear.app/stream/issue/RN-151/improve-channel-preview-hooks-performance-and-seek-for-improvements