feat: add support for expo-audio
#3126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SDK Size
|
oliverlaz
approved these changes
Jun 20, 2025
khushal87
approved these changes
Jun 23, 2025
Member
khushal87
left a comment
khushal87
left a comment
There was a problem hiding this comment.
Approving it. Just take care of the expo-audio bug shared on slack
Contributor
Author
Done, as discussed offline. Thanks for the detailed review ! |
# Conflicts: # package/expo-package/package.json
Contributor
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR adds support for the
expo-audiolibrary. The reason why we need to do this now is the fact that inexpo-avis going to be completely removed startingExpo 54and is now not supported at all for more recent versions ofExpo.However, since we support versions
>=51.0.0in the SDK, this made it impossible to:expo-audio(it's unavailable in51and is very early beta in52)expo-av(it's going to be completely gone in the near future and is likely very unstable on53as well)Expoversion to53in V8 because it's too big of a jumpSo, we have to support both for a while.
I played around with this quite a bit today and managed to resolve everything through adapters and interfacing. For now, the APIs we use from
expo-avare deemed the default ones so that I don't have to do a bunch of UI changes too. The imperative approach was also taken forexpo-audio(not using their hooks at all) in order to make this possible. We can ditchexpo-avcompletely onceExpo 53becomes baseline for our SDK.🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch