feat: add disabled prop to ChatAutoComplete#2613
Closed
sergeichestakov wants to merge 1 commit intoGetStream:masterfrom
Closed
feat: add disabled prop to ChatAutoComplete#2613sergeichestakov wants to merge 1 commit intoGetStream:masterfrom
sergeichestakov wants to merge 1 commit intoGetStream:masterfrom
Conversation
Contributor
|
Closing in favor of #2617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Per convo in our shared Slack channel, I thought it would be useful if you could pass in a
disabledprop to theChatAutoCompletecomponent which would be forwarded to the underlying textArea component. This becomes useful when implementing a customInputcomponent so that you can disable the text area from within the component instead of having to hoist state one level up and pass in a prop into theMessageInputinstead which can lead to unnecessary rerenders of the parent component and feels like an extra level of indirection.🛠 Implementation details
Add support for a
disabledprop in theChatAutoCompletecomponent which overwrites and takes precedence over the initial disabled logic and corresponding message input context value.🎨 UI Changes
N/A