fix: regenerate image preview URL on image attachment removal when editing a message #2775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +136 B (+0.01%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Jul 15, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2775 +/- ##
==========================================
- Coverage 81.28% 81.25% -0.03%
==========================================
Files 479 479
Lines 9530 9532 +2
Branches 2217 2162 -55
==========================================
- Hits 7746 7745 -1
- Misses 1413 1679 +266
+ Partials 371 108 -263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 13.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes #2773
🛠 Implementation details
The effect had a condition that imageElements array could not contain null in order to recalculate preview urls. That lead to the issue in scenario when images at the beginning of the attachment array were removed. The preview URL of removed attachment was assigned based on index to an attachment that moved to the place of the previously removed image.