-
Notifications
You must be signed in to change notification settings - Fork 231
[CI] Support Xcode 26 #3825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Support Xcode 26 #3825
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14366,6 +14366,7 @@ | |
| "PROVISIONING_PROFILE_SPECIFIER[sdk=macosx*]" = ""; | ||
| SKIP_INSTALL = YES; | ||
| SUPPORTED_PLATFORMS = "iphonesimulator iphoneos macosx"; | ||
| SWIFT_OPTIMIZATION_LEVEL = "-Osize"; | ||
laevandus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| SWIFT_VERSION = 5.0; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainAlign Swift language version with the PR’s minimum Swift bump. This target still declares Apply this change here: - SWIFT_VERSION = 5.0;
+ SWIFT_VERSION = 5.9;Then audit the repo for any stragglers: 🏁 Script executed: #!/bin/bash
# Find all SWIFT_VERSION occurrences and show surrounding context
rg -n -C2 'SWIFT_VERSION\s*=\s*' \
StreamChat.xcodeproj/project.pbxproj \
-g '!*DerivedData*'
# Check Package.swift and podspecs declare the same minimum Swift
fd -t f -a --hidden 'Package.swift|*.podspec|*.xcconfig'
rg -n 'swift-tools-version|swift_version' -g 'Package.swift|**/*.podspec|**/*.xcconfig'Length of output: 12877 🏁 Script executed: #!/bin/bash
# Find Package.swift and podspec files properly
find . -name "Package.swift" -type f 2>/dev/null | head -20
find . -name "*.podspec" -type f 2>/dev/null | head -20Length of output: 127 🏁 Script executed: #!/bin/bash
# Check swift-tools-version in Package.swift
echo "=== Package.swift swift-tools-version ==="
rg -n 'swift-tools-version|swiftLanguageVersions' Package.swift
# Check s.swift_version in podspec files
echo -e "\n=== Podspec swift_version declarations ==="
rg -n 's\.swift_version' StreamChat.podspec StreamChatUI.podspec
# Also check for any version metadata
echo -e "\n=== StreamChat.podspec version lines ==="
head -20 StreamChat.podspec | rg -n 'version|swift'
echo -e "\n=== StreamChatUI.podspec version lines ==="
head -20 StreamChatUI.podspec | rg -n 'version|swift'Length of output: 651 Align Swift language version with SPM and CocoaPods minimums. The Xcode project declares Apply this change across all 60+ occurrences in - SWIFT_VERSION = 5.0;
+ SWIFT_VERSION = 5.9;Verify the update by running: #!/bin/bash
rg -n 'SWIFT_VERSION\s*=\s*' StreamChat.xcodeproj/project.pbxproj | grep -v 5.9🤖 Prompt for AI Agents |
||
| TARGETED_DEVICE_FAMILY = "1,2"; | ||
| }; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix markdown list indentation to align with formatting standards.
Static analysis detected inconsistent indentation in nested list items:
These should be corrected to maintain consistent markdown formatting across the CHANGELOG.
And similarly for line 395:
- Add `CurrentUserController`: - `deleteDraft()` - `loadDraftMessages()` -~ - `loadMoreDraftMessages()` + - `loadMoreDraftMessages()`Also applies to: 395-395
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
258-258: Unordered list indentation
Expected: 2; Actual: 3
(MD007, ul-indent)
🤖 Prompt for AI Agents