Upload photos from the library as JPEG instead of HEIC #767
Conversation
SDK Size
|
| private func assetJpgURL() -> URL? { | ||
| guard let assetURL = assetURL else { return nil } | ||
| guard let assetData = try? Data(contentsOf: assetURL) else { return nil } | ||
| return try? UIImage(data: assetData)?.temporaryLocalFileUrl() |
There was a problem hiding this comment.
Not for this PR, but I did not know that temporaryLocalFileUrl actually goes and converts the image to JPEG. We should probably rename this at some point.
I guess this is fast enough that we don't need any async call for this.
There was a problem hiding this comment.
Yeah I actually changed it and then reverted it. But I think we can do it already here. It makes sense to rename it on UIKit as well.
There was a problem hiding this comment.
I guess this is fast enough that we don't need any async call for this.
Yes it is quite fast, and is also only executed when an attachment is added to the composer
There was a problem hiding this comment.
Done ✅ Let me know WDYT
|
🔗 Issue Link
#759
🎯 Goal
Send photos from the library as JPEG instead of HEIC to make sure other platforms can show the images correctly.
🛠 Implementation
We now convert the HEIC image to JPG when adding it to the composer.
This approach is what we do when sending photos from the Camera. With this change, we are also consistent with UIKit as well which follows the same approach.
🧪 Testing
Smoke testing around images
☑️ Checklist