Skip to content

Upload photos from the library as JPEG instead of HEIC #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nuno-vieira merged 4 commits into from
Mar 3, 2025
Merged

Upload photos from the library as JPEG instead of HEIC #767

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7442c74
Send photos from the library as jpeg instead of heic
nuno-vieira Feb 28, 2025
91df05d
Update CHANGELOG.md
nuno-vieira Feb 28, 2025
a5cc426
Update CHANGELOG.md
nuno-vieira Feb 28, 2025
5c5b4a5
Improve the name of the function
nuno-vieira Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
# Upcoming

### 🔄 Changed
- Uploading a HEIC photo from the library is now converted to JPEG for better compatibility [#767](https://github.com/GetStream/stream-chat-swiftui/pull/767)

# [4.73.0](https://github.com/GetStream/stream-chat-swiftui/releases/tag/4.73.0)
_February 28, 2025_
Expand Down
11 changes: 10 additions & 1 deletion Sources/StreamChatSwiftUI/ChatChannel/Composer/PhotoAttachmentPickerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public struct PhotoAttachmentCell: View {
.allowsHitTesting(true)
.onTapGesture {
withAnimation {
if let assetURL = assetURL {
if let assetURL = assetJpgURL() {
onImageTap(
AddedAsset(
image: image,
Expand Down Expand Up @@ -193,4 +193,13 @@ public struct PhotoAttachmentCell: View {
}
}
}

/// The original photo is usually in HEIC format.
/// This makes sure that the photo is converted to JPG.
/// This way it is more compatible with other platforms.
private func assetJpgURL() -> URL? {
guard let assetURL = assetURL else { return nil }
guard let assetData = try? Data(contentsOf: assetURL) else { return nil }
return try? UIImage(data: assetData)?.temporaryLocalFileUrl()
Copy link
Contributor

@laevandus laevandus Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but I did not know that temporaryLocalFileUrl actually goes and converts the image to JPEG. We should probably rename this at some point.

I guess this is fast enough that we don't need any async call for this.

Copy link
Member Author

@nuno-vieira nuno-vieira Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I actually changed it and then reverted it. But I think we can do it already here. It makes sense to rename it on UIKit as well.

Copy link
Member Author

@nuno-vieira nuno-vieira Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fast enough that we don't need any async call for this.

Yes it is quite fast, and is also only executed when an attachment is added to the composer

Copy link
Member Author

@nuno-vieira nuno-vieira Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅ Let me know WDYT

}
}
Loading