-
Notifications
You must be signed in to change notification settings - Fork 112
Allow dismissing commands overlay and attachments picker on message list tap #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nuno-vieira
merged 8 commits into
develop
from
add/dismiss-commands-and-attachments-on-message-list-tap
Oct 21, 2025
Merged
Allow dismissing commands overlay and attachments picker on message list tap #1024
nuno-vieira
merged 8 commits into
develop
from
add/dismiss-commands-and-attachments-on-message-list-tap
Oct 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmitrevski
approved these changes
Oct 21, 2025
Public Interface public struct MessageListConfig
- public let bouncedMessagesAlertActionsEnabled: Bool
+ public let hidesCommandsOverlayOnMessageListTap: Bool
- public let skipEditedMessageLabel: (ChatMessage) -> Bool
+ public let hidesAttachmentsPickersOnMessageListTap: Bool
- public let draftMessagesEnabled: Bool
+ public let bouncedMessagesAlertActionsEnabled: Bool
- public let downloadFileAttachmentsEnabled: Bool
+ public let skipEditedMessageLabel: (ChatMessage) -> Bool
-
+ public let draftMessagesEnabled: Bool
-
+ public let downloadFileAttachmentsEnabled: Bool
- public init(messageListType: MessageListType = .messaging,typingIndicatorPlacement: TypingIndicatorPlacement = .bottomOverlay,groupMessages: Bool = true,messageDisplayOptions: MessageDisplayOptions = MessageDisplayOptions(),messagePaddings: MessagePaddings = MessagePaddings(),dateIndicatorPlacement: DateIndicatorPlacement = .overlay,pageSize: Int = 25,messagePopoverEnabled: Bool = true,doubleTapOverlayEnabled: Bool = false,becomesFirstResponderOnOpen: Bool = false,resignsFirstResponderOnScrollDown: Bool = true,updateChannelsFromMessageList: Bool = false,maxTimeIntervalBetweenMessagesInGroup: TimeInterval = 60,cacheSizeOnChatDismiss: Int = 1024 * 1024 * 100,iPadSplitViewEnabled: Bool = true,scrollingAnchor: UnitPoint = .center,showNewMessagesSeparator: Bool = true,handleTabBarVisibility: Bool = true,messageListAlignment: MessageListAlignment = .standard,uniqueReactionsEnabled: Bool = false,localLinkDetectionEnabled: Bool = true,isMessageEditedLabelEnabled: Bool = true,markdownSupportEnabled: Bool = true,userBlockingEnabled: Bool = false,bouncedMessagesAlertActionsEnabled: Bool = true,skipEditedMessageLabel: @escaping (ChatMessage) -> Bool = { _ in false },draftMessagesEnabled: Bool = false,downloadFileAttachmentsEnabled: Bool = false)
+
+
+ public init(messageListType: MessageListType = .messaging,typingIndicatorPlacement: TypingIndicatorPlacement = .bottomOverlay,groupMessages: Bool = true,messageDisplayOptions: MessageDisplayOptions = MessageDisplayOptions(),messagePaddings: MessagePaddings = MessagePaddings(),dateIndicatorPlacement: DateIndicatorPlacement = .overlay,pageSize: Int = 25,messagePopoverEnabled: Bool = true,doubleTapOverlayEnabled: Bool = false,becomesFirstResponderOnOpen: Bool = false,resignsFirstResponderOnScrollDown: Bool = true,updateChannelsFromMessageList: Bool = false,maxTimeIntervalBetweenMessagesInGroup: TimeInterval = 60,cacheSizeOnChatDismiss: Int = 1024 * 1024 * 100,iPadSplitViewEnabled: Bool = true,scrollingAnchor: UnitPoint = .center,showNewMessagesSeparator: Bool = true,handleTabBarVisibility: Bool = true,messageListAlignment: MessageListAlignment = .standard,uniqueReactionsEnabled: Bool = false,localLinkDetectionEnabled: Bool = true,isMessageEditedLabelEnabled: Bool = true,markdownSupportEnabled: Bool = true,userBlockingEnabled: Bool = false,bouncedMessagesAlertActionsEnabled: Bool = true,skipEditedMessageLabel: @escaping (ChatMessage) -> Bool = { _ in false },draftMessagesEnabled: Bool = false,downloadFileAttachmentsEnabled: Bool = false,hidesCommandsOverlayOnMessageListTap: Bool = true,hidesAttachmentsPickersOnMessageListTap: Bool = true) |
|
Collaborator
SDK Size
|
Collaborator
StreamChatSwiftUI XCSize
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


🔗 Issue Links
https://linear.app/stream/issue/IOS-1182
🎯 Goal
Allow dismissing commands overlay and attachments picker on message list tap.
📝 Summary
Both are enabled by default since it is what most customers will want. A feature flag has been added for customers who want to disable this.
🛠 Implementation
In order not to cause a breaking change, I used NSNotifications to notify the composer view that it needs to hide the commands overlay or the attachments picker from the channel view.
Note
At the moment, the commands overlay is coupled with the command in the composer. So if there is a command selected already, hiding the overlay will remove the command from the composer. Changing this is out of scope since it would probably cause breaking changes, but in the future, it would be nice if these were decoupled like in UIKit.
🧪 Manual Testing Notes
Commands Overlay
Attachments Picker
☑️ Contributor Checklist
docs-contentrepo