Skip to content

Make cron checks work on v5 #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Nov 13, 2025
Merged

Make cron checks work on v5 #1048

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d50d7c9
Use StreamCore based chat
laevandus Nov 4, 2025
bb5cc83
Test typealias over @_exported
laevandus Nov 4, 2025
a3b2f2e
Revert "Test typealias over @_exported"
laevandus Nov 4, 2025
9a939c0
Add foundation import
laevandus Nov 4, 2025
ed25e50
Remove duplicate Identifiable conformances
laevandus Nov 5, 2025
ac07f8f
Link StreamCore and StreamChat dynamically for size calculation
laevandus Nov 5, 2025
317c77e
Merge branch 'v5' into v5-stream-core
laevandus Nov 6, 2025
424bf5a
Merge branch 'v5' into v5-stream-core
laevandus Nov 10, 2025
d1347a1
Bump xcsize version
testableapple Nov 10, 2025
2bd5098
Race between logout and login in UI-tests
laevandus Nov 10, 2025
d8e283b
Keep logout before connect
laevandus Nov 10, 2025
8315dd8
Update xcode version on cron checks
testableapple Nov 10, 2025
b381172
Merge branch 'v5' into v5-cron-checks
laevandus Nov 11, 2025
1015f08
Merge branch 'v5' into v5-cron-checks
laevandus Nov 11, 2025
c4b50c7
Merge branch 'v5' into v5-cron-checks
laevandus Nov 11, 2025
6ac82fe
Fix XCFrameworks build
laevandus Nov 12, 2025
2072ac5
Enable old xcode checks
testableapple Nov 12, 2025
258859a
Test another device
testableapple Nov 12, 2025
3b47c19
Change device
testableapple Nov 12, 2025
b362eba
Change macos
testableapple Nov 12, 2025
d1cba8b
revert branch
testableapple Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/cron-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,19 @@ jobs:
# setup_runtime: false
- ios: "18.5"
device: "iPhone 16 Pro"
xcode: "26.0.1"
setup_runtime: false
- ios: "17.5"
device: "iPhone 15 Pro"
xcode: "26.0.1"
setup_runtime: true
- ios: "16.4"
device: "iPhone 14 Pro"
xcode: "16.4"
setup_runtime: true
fail-fast: false
runs-on: macos-15
env:
GITHUB_EVENT: ${{ toJson(github.event) }}
ALLURE_TOKEN: ${{ secrets.ALLURE_TOKEN }}
XCODE_VERSION: ${{ matrix.xcode }}
XCODE_VERSION: "26.0.1"
steps:
- uses: actions/[email protected]
- uses: ./.github/actions/bootstrap
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/smoke-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
build-old-xcode:
name: Build SDKs (Old Xcode)
runs-on: macos-14
if: false # Disabled for now ${{ github.event.inputs.record_snapshots != 'true' }}
if: ${{ github.event.inputs.record_snapshots != 'true' }}
env:
XCODE_VERSION: "16.1"
steps:
Expand All @@ -78,7 +78,7 @@ jobs:
- uses: ./.github/actions/xcode-cache
- uses: ./.github/actions/ruby-cache
- name: Build SwiftUI
run: bundle exec fastlane test_ui device:"iPhone 16" build_for_testing:true
run: bundle exec fastlane test_ui device:"iPhone 16 (18.1)" build_for_testing:true
timeout-minutes: 25
- name: Build XCFrameworks
run: bundle exec fastlane build_xcframeworks
Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/AddUsersViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import StreamChat
import SwiftUI

Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/ChatChannelInfoViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import Foundation
import StreamChat
import SwiftUI
Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/FileAttachmentsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import Foundation
import StreamChat
import SwiftUI
Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/MediaAttachmentsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import Foundation
import StreamChat
import SwiftUI
Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/ChannelInfo/PinnedMessagesViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import Foundation
import StreamChat
import SwiftUI
Expand Down
2 changes: 2 additions & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/ChatChannelViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,8 @@ import SwiftUI
}
case .move:
continue
@unknown default:
continue
}
}

Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/Composer/PhotoAssetsUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import Photos
import StreamChat
import SwiftUI
Expand Down
1 change: 1 addition & 0 deletions ...mChatSwiftUI/ChatChannel/MessageList/AsyncVoiceMessages/VoiceRecordingContainerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import StreamChat
import SwiftUI

Expand Down
2 changes: 2 additions & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/MessageList/AttachmentDownloadingStateView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ struct AttachmentDownloadingStateView: View {

case .downloaded:
EmptyView()
@unknown default:
EmptyView()
}
}
.id("\(url.absoluteString)-\(downloadState.state))")
Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/MessageList/MessageRepliesView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import StreamChat
import SwiftUI

Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/MessageList/Polls/PollAttachmentViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import StreamChat
import SwiftUI

Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/Reactions/MessageActions/MessageActionsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import StreamChat
import SwiftUI

Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannel/Reactions/ReactionsUsersViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import StreamChat
import SwiftUI

Expand Down
1 change: 1 addition & 0 deletions Sources/StreamChatSwiftUI/ChatChannelList/MoreChannelActionsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Copyright © 2025 Stream.io Inc. All rights reserved.
//

import Combine
import Foundation
import StreamChat
import SwiftUI
Expand Down
2 changes: 1 addition & 1 deletion StreamChatSwiftUI.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3871,7 +3871,7 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/GetStream/stream-chat-swift.git";
requirement = {
branch = v5;
branch = "v5-cron-checks";
kind = branch;
};
};
Expand Down
Loading